-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error while Packaging simple App - The "path" argument must be of type string. Received undefined #126
Closed
JNBG opened this issue
Nov 22, 2021
· 4 comments
· Fixed by RocketChat/Rocket.Chat.Apps-compiler#44 or RocketChat/Rocket.Chat.Apps-compiler#47
Closed
Error while Packaging simple App - The "path" argument must be of type string. Received undefined #126
JNBG opened this issue
Nov 22, 2021
· 4 comments
· Fixed by RocketChat/Rocket.Chat.Apps-compiler#44 or RocketChat/Rocket.Chat.Apps-compiler#47
Comments
@JNBG Hello, is there any fix? did you find it? |
@jayeshdesai4520 so far no - but I didn't really find the time to work on it yet |
It seems I found a problemed code. It's in "bundler/esbuild.ts" This function works on Linux, however doesn't work on Windows. function normalizeAppModulePath(modulePath: string, parentDir: string): string {
return /\.\.?\//.test(modulePath)
? path.resolve('/', path.dirname(parentDir), modulePath).substring(1).concat('.js')
: modulePath;
} |
Hi! Please see my PR that fixes this problem RocketChat/Rocket.Chat.Apps-compiler#47 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Tried building my first App. Followed the Tutorial here
All went well until adding a Slash Command and then packaging the App. On using the
rc-apps deploy
Command the App breaks on packaging with following Error:Whenever I remove the part where it's extending the Configuration for the Slash Command everything runs well and get's uploaded to my test-server.
The LiftoffCommand is 1:1 Copy from the Tutorial.
I am running this on:
@rocket.chat/apps-cli/1.10.1 win32-x64 node-v12.18.1
You can find a reproduction Repo here
The text was updated successfully, but these errors were encountered: