Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning of using eval statements is highly discouraged from the RC Node.js SDK #9

Open
sidmohanty11 opened this issue Jun 30, 2022 · 3 comments
Open

Warning of using eval statements is highly discouraged from the RC Node.js SDK #9

sidmohanty11 opened this issue Jun 30, 2022 · 3 comments
Labels
bug Something isn't working tech-debt not resolved yet as it is not resolved somewhere else

Comments

@sidmohanty11
Copy link
Collaborator

Description: The current Rocket.Chat Nodejs SDK has js-sha256 as its dependency which is showing the warning message.

Rocket.Chat Nodejs SDK v1.0.0-alpha.42

LINKED ISSUE IN RC Node.js SDK: issue

Steps to reproduce:

  1. npm run build and you will see it in the terminal

Expected behavior:

Not to show any warning message.

Actual behavior:

Shows a warning message.

image
@sidmohanty11 sidmohanty11 added the bug Something isn't working label Jun 30, 2022
@sidmohanty11 sidmohanty11 mentioned this issue Jul 9, 2022
Open
@sidmohanty11
Copy link
Collaborator Author

Made a PR here, which will resolve this issue

@sidmohanty11 sidmohanty11 added the tech-debt not resolved yet as it is not resolved somewhere else label Nov 8, 2022
@VipinDevelops
Copy link
Contributor

VipinDevelops commented Jan 3, 2023 •
edited
Loading

This PR should be merged ASAP this eval error is annoying

@kalyanram360
Copy link

kalyanram360 commented Dec 24, 2023 •
edited
Loading

I want to contribute for this
but I am not understanding what is the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working tech-debt not resolved yet as it is not resolved somewhere else
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sidmohanty11 @VipinDevelops @kalyanram360