-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lazily load shepherd dependency #304
Comments
@st-h this sounds like a good idea to me. The main reason we are using ember-cli-node-assets, is so we can allow the consumer to specify a theme in the config and to wrap Shepherd in a fastboot transform, so it does not attempt to use |
thanks for the input. I will give it a try, however I am currently not sure how to exactly deal with the templating/fastboot stuff. |
@st-h Shepherd is not included when running in fastboot and it should not be. |
@rwwagner90 thanks. I'll see if I can find the reason for the exception I occasionally see as well. just attaching the trace for reference here:
|
Looks like it is from body-scroll-lock. That's not from Shepherd, it is here in ember-shepherd https://github.com/shipshapecode/ember-shepherd/blob/master/package.json#L59 We should probably move the disableScroll functionality into Shepherd as well, then this would be fixed. |
I think moving disableScroll to shepherd.js is a nice idea. That way we can also lazy load it without having to do anything :D |
I was wondering if we could use ember-auto-import to allow lazy loading of the shepherd dependency? The shepherd dependency currently is the largest external one within my app, however might not be required at all.
I'll be happy to submit a PR, but wanted to check first if you would be interested in this
The text was updated successfully, but these errors were encountered: