-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
copyStyles does not update on resize #16
Comments
That is correct. It would be pretty intensive to copy the styles each time the browser resized. Perhaps we can do some debouncing and make something work here though. |
@davidpike7 is this issue stopping you from using ember-shepherd? |
Not at all. We just simplified our CSS to remove the need to use copyStyles. Now its working great |
Okay, great. I would be open to a PR or suggestions on how to get copyStyles to be responsive, but it's not high on my priority list at this time. Would you be interested in giving it a go? |
To be honest I don't think its particular high for us either now that we've got the issue sorted. Happy to help out elsewhere though if you're needing some help. |
Well right now we have most of the functionality and everything that we wanted to accomplish. We're always looking to make it better though, so we'd be glad to have you take a look. Any ideas for features or improvements? |
I think we'll close this in favor of people fixing styles on their end. copyStyles can be an intensive process, and recalculating it all on the fly doesn't sound like a good idea. |
Currently the copyStyles does not update the positioning of the copied element on browser resize
The text was updated successfully, but these errors were encountered: