-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent PR template insertion when the textarea is already populated #49
Comments
oof, that sounds nasty! Good suggestion. Will see if I have time to implement this, probably shouldn't be too hard! |
Fixed in v1.3.0 |
@RobQuistNL @blakegearin, this was the exact feature that has been working for me for the last 2 years. Now, the template doesn't even show up while creating a new PR :( Is there any workaround? |
hmm, can you make me some reproduction steps @rishabh-sagar-20 ? |
@RobQuistNL, when creating a new PR, GitHub automatically fills in the Title and Description fields using one of the initial commits from the branch. However, since we are now checking for empty values before applying the default template, this causes an issue because GitHub has already populated these fields. I recommend adding an option to control this behavior, which would help resolve the problem. |
@rishabh-sagar-20 |
You mean there's a "PR Template" in the .github folder in the repo and thats not being overwritten by this extension? In my opinion thats by design - I don't want to overwrite any repo specific PR templates. Or are you talking about something else? If its the first case, maybe we can add a button to "force" the Github-Jira PR template. |
@RobQuistNL, It's not a repository-specific template; GitHub fills it in during the initial page load. The "force" button should work. |
@blakegearin, it was not working in my case somehow. I will give it a try again. |
Is this repository you talk about public, so I can check it out? Because if what you're saying is happening it means it shouldn't work at all for any PR. 🤔 |
Steps to Reproduce
The text was updated successfully, but these errors were encountered: