fixing issue where we don't supply the updated passwords #52
Conversation
| @@ -4,7 +4,7 @@ | |||
| license "Apache 2.0" | |||
| description "Installs/Configures nexus" | |||
| long_description IO.read(File.join(File.dirname(__FILE__), 'README.md')) | |||
| version "2.2.0" | |||
| version "2.2.1" | |||
There was a problem hiding this comment.
We (Riot) should manage the bumping of the version number.
|
Thank you for this! I am 👍 on this once the version change to metadata.rb is reverted and this pull merges cleanly. I have been thinking a bit about this, and I think maybe some of these extra resources should be removed. From my perspective, maybe we should install the nexus (and associated software) and leave everything else alone - in this example, not changing the default admin password. The LWRPs included with this cookbook are helpful for configuring your Nexus server once it is running - including changing a user's password. Traditionally at Riot, we create a wrapper cookbook that depends on this base cookbook, and then customize our server using recipes in the wrapper cookbook which use this cookbook's LWRPs. Personally, I like the pattern described above. What do you think? |
|
I'd agree with what you described of decoupling the use of that LWRP. |
fixing issue where we don't supply the updated passwords
Found that we couldn't turn off the update of admin credentials in Chef 11.6.2 because of compilation issue when updated_credentials doesn't exist in data bag