Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function to fetch valid currency codes #46

Open
ohjakobsen opened this issue Mar 30, 2023 · 0 comments
Open

Add function to fetch valid currency codes #46

ohjakobsen opened this issue Mar 30, 2023 · 0 comments
Assignees
Labels
Milestone

Comments

@ohjakobsen
Copy link
Contributor

If the user provides and invalid currency code to get_exchange_rate(), an error is returned. A list of valid codes are available from a link in the documentation, but this is not very transparent for the user. Since we already provide a list of valid codes internally, we should create a function to make this information available to the user. Such a function could be called list_valid_currencies(). When an error is returned from get_exchange_rate() because of an invalid currency code, we could tip the user to list valid codes with list_valid_currencies().

@ohjakobsen ohjakobsen added this to the v0.2.0 milestone Mar 30, 2023
@ohjakobsen ohjakobsen self-assigned this Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants