Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Angular typescript client generation support for DeepObject #1665

Open
fivage opened this issue Oct 12, 2018 · 2 comments
Open

Angular typescript client generation support for DeepObject #1665

fivage opened this issue Oct 12, 2018 · 2 comments
Labels
help wanted project: NSwag.CodeGeneration.TypeScript type: bug

Comments

@fivage
Copy link

fivage commented Oct 12, 2018

I think the section from /src/NSwag.CodeGeneration.CSharp/Templates/Client.Class.QueryParameter.liquid

{% elseif parameter.IsDeepObject -%}

must also be added to the typescript version in /src/NSwag.CodeGeneration.TypeScript/Templates/Client.RequestUrl.liquid for correct DeepObject suppor.
@RicoSuter
Copy link
Owner

RicoSuter commented Oct 31, 2018 •
edited
Loading

@crfloyd can you quickly check this? sorry to bother you, it's TypeScript

Ref: #1342

@RicoSuter
Copy link
Owner

Deep objects are not yet supported by the TypeScript templates... probably more is needed than just adding this line :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted project: NSwag.CodeGeneration.TypeScript type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RicoSuter @fivage