Inheritance Wiki

[alb3ric]

Hello,

I'm trying to generate a schema with inheritance.
I try the sample code in the wiki (Animal, Dog) but the schema generated is different from the wiki (9.12.7).
I get the result below. Nno oneOf but mappings instead. Why?

{
"$schema": "http://json-schema.org/draft-04/schema#",
"title": "Container",
"type": "object",
"additionalProperties": false,
"properties": {
"Animal": {
"$ref": "#/definitions/Animal"
}
},
"definitions": {
"Animal": {
"type": "object",
"discriminator": {
"propertyName": "discriminator",
"mapping": {
"Dog": "#/definitions/Dog"
}
},
"additionalProperties": false,
"required": [
"discriminator"
],
"properties": {
"discriminator": {
"type": "string"
},
"Foo": {
"type": "string"
}
}
},
"Dog": {
"allOf": [
{
"$ref": "#/definitions/Animal"
},
{
"type": "object",
"additionalProperties": false,
"properties": {
"Bar": {
"type": "string"
}
}
}
]
}

Thanks in advance for your help.

Regards

alb3ric

[thebestnom]

Im pretty sure thats the spec, no? Have you tried codegen it back to see what would it generate to?

[RicoSuter]

This is as expected: Swagger uses all of with the first element the base schema and the second the schema itself

[alb3ric]

Hello,

Ok, thanks for your answers.
I had in my sample a class called "Cat" extending Animal.
What I would have like as a result is this (see below). Is this against the specs?

{
"$schema": "http://json-schema.org/draft-04/schema#",
"title": "Container",
"type": "object",
"additionalProperties": false,
"properties": {
"Animal": {
"oneOf": [
{
"$ref": "#/definitions/Dog"
},
{
"$ref": "#/definitions/Cat"
}
]
}
},
"definitions": {
"Animal": {
"type": "object",
"discriminator": {
"propertyName": "discriminator",
"mapping": {
"Dog": "#/definitions/Dog",
"Cat": "#/definitions/Cat"
}
},
"x-abstract": true,
"additionalProperties": false,
"required": [
"discriminator"
],
"properties": {
"Foo": {
"type": [
"null",
"string"
]
},
"discriminator": {
"type": "string"
}
}
},
"Dog": {
"allOf": [
{
"$ref": "#/definitions/Animal"
},
{
"type": "object",
"additionalProperties": false,
"properties": {
"Ouaf": {
"type": [
"null",
"string"
]
}
}
}
]
},
"Cat": {
"allOf": [
{
"$ref": "#/definitions/Animal"
},
{
"type": "object",
"additionalProperties": false,
"properties": {
"Miaou": {
"type": [
"null",
"string"
]
}
}
}
]
}
}
}

[RicoSuter]

BTW: This only works for swagger/openapi. For json schema validation you’d indeed need oneof inheritance - there’s an open issue for that: #13

[alb3ric]

Ok, I'm in a json schema case.
I'll have a look at the open issue

Thx!