Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System.Text.Json TypeDiscriminator property type is not string #1723

Closed
david-brink-talogy opened this issue Aug 14, 2024 · 0 comments · Fixed by #1724
Closed

System.Text.Json TypeDiscriminator property type is not string #1723

david-brink-talogy opened this issue Aug 14, 2024 · 0 comments · Fixed by #1724

Comments

@david-brink-talogy
Copy link
Contributor

STJ's JsonDerivedTypeAttribute.TypeDiscriminator is of type object?. It looks like NJsonSchema always expects a STJ discriminator of type string based on the return type of SystemTextJsonInheritanceWrapper.GetDiscriminatorValue.

Is there a reason for this assumption? If not, does changing the return type of GetDiscriminatorValue to object? raise any red flags?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for non-string discriminators using System.Text.Json david-brink-talogy/NJsonSchema
1 participant
@david-brink-talogy