Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specialized enums for interpreter impl #67

Open
Rudxain opened this issue Mar 22, 2023 · 3 comments
Open

specialized enums for interpreter impl #67

Rudxain opened this issue Mar 22, 2023 · 3 comments

Comments

@Rudxain
Copy link
Member

Rudxain commented Mar 22, 2023

I was just reading this, and found this. And I realized it would be a good idea to replace the string-only enums by this, to avoid the generic Enum class.

We also get some benefits, such as:

  • auto(), to reduce boilerplate
  • implicit string conversion, to avoid appending .value suffix every-time

I opened this issue to remind myself to open a PR for this. So I want to be "assigned" (in the GitHub context) to this issue.

I'll implement this later. I'm busy right now

@Rudxain
Copy link
Member Author

Rudxain commented Mar 22, 2023

Nevermind. It requires Py v3.11 (and the README says 3.6)

@Rudxain Rudxain closed this as not planned Won't fix, can't repro, duplicate, stale Mar 22, 2023
@SatinWukerORIG
Copy link
Member

I am sorry that this is a very late reply. Thank you for all of your contributions, and I recently also went back to work on this project, therefore I fixed numerous bugs and added a little more features to the parser. As I was writing the code, indeed I found that adding .value to ever KW is quite complicated and a little bit annoying lol. Don't worry about the readme, we can change it ;)
So continue working on this! 👍👍👍

@Rudxain Rudxain reopened this Jun 18, 2023
@Rudxain Rudxain changed the title More specific enums specialized enums Mar 14, 2024
@Rudxain
Copy link
Member Author

Rudxain commented Mar 14, 2024

I'm sorry for the wait. I'll implement this soon. I was (and still am) busy

@Rudxain Rudxain changed the title specialized enums specialized enums for interpreter impl Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants