Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the Request objects #6

Open
acuthbert opened this issue Feb 16, 2015 · 1 comment
Open

Refactor the Request objects #6

acuthbert opened this issue Feb 16, 2015 · 1 comment

Comments

@acuthbert
Copy link
Contributor

When I integrated the Http/HttpRequest object into the main Crown module it seemed silly to have two different Request objects in the one library. They both model the same thing so we should have a common ancestor in there object hierarchy. While we're at it, there is a PSR recommended interface for http request objects:

https://packagist.org/packages/psr/http-message

Interestingly they call it a message rather than a request. We should future proof ourselves by working with this interface if we want to stay php-fig compliant.

@acuthbert acuthbert added this to the 1.1 milestone Feb 16, 2015
@acuthbert
Copy link
Contributor Author

Not sure if this makes sense? The HttpRequest includes an addHeader() function for example which is used to set headers which makes no sense for an incoming request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant