New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a destroy method. #147

Closed

samussiah opened this issue May 20, 2019 · 0 comments · Fixed by #148

Labels

Milestone

Contributor

samussiah commented May 20, 2019 •

edited

Loading

That not only clears the contents of the containing element and the Webcharts object(s), but the stylesheet as well.

Test notes

Open the developer console.
On the Elements tab expand the <head> element and verify that the last child node is a <style> element and that its styles include .query-overview classes.
On the Console tab run d3.select('.query-overview').node() and verify the Query Overview <div> element is returned.
Run d3.select('.wc-chart').datum().destroy() and verify both the <style> element and <div> element are removed from the DOM.

Reference the images in this crf-heat-map issue for screenshots.

The text was updated successfully, but these errors were encountered:

samussiah added the High Priority label

samussiah added this to the v2.1.1 milestone

samussiah mentioned this issue

Support chart.destroy() #54

Closed

samussiah mentioned this issue

Query Overview v2.1.1 #148

Merged

samussiah closed this as completed in #148

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment