Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PushSharp 3 is not strong signed. #607

Closed
MosheL opened this issue Jan 27, 2016 · 9 comments
Closed

PushSharp 3 is not strong signed. #607

MosheL opened this issue Jan 27, 2016 · 9 comments

Comments

@MosheL
Copy link

MosheL commented Jan 27, 2016

I was forced to upgrade as PushSharp 2 do not recognize my new keys.

Trying to upgrade from 2.x to 3 on a test Windows Application - works.
Trying to use it on the main app - can't, becase of the DLLs is not strong typed.

trying to manually sign the keys - failed, as one DLL depend other one and NuGet is overwriting these files.

What I can do? It can be fixed on the main branch ?

thanks

@Redth
Copy link
Owner

Redth commented Jan 27, 2016

I'd really prefer not to sign the assemblies, is there a particular reason you must use signed assemblies?

If I do decide to sign them I'll most likely include the .snk file and password for it right in the source project so folks don't have issues compiling from source.

@Redth
Copy link
Owner

Redth commented Jan 27, 2016

Also, you can also pull the source, compile, and sign it yourself if you're really desperate :)

@Redth
Copy link
Owner

Redth commented Jan 27, 2016

Furthermore, there's a pretty good explanation of why strong naming assemblies is probably not necessary: octokit/octokit.net#405 (comment)

@MosheL
Copy link
Author

MosheL commented Jan 27, 2016

Hi !

  1. Thanks
  2. I need it because I am using DLL to DLL, so VS/IIS is forcing me to sign them.

@Redth
Copy link
Owner

Redth commented Jan 27, 2016

You can also use ILRepack or https://github.com/brutaldev/StrongNameSigner to accomplish signing.

Can you elaborate on 2? I'm not familiar with what 'DLL to DLL' means exactly.

@MosheL
Copy link
Author

MosheL commented Jan 27, 2016

as I know, I cant use non-signed DLL via other DLL on web project. I see a strange errors...

@MosheL
Copy link
Author

MosheL commented Jan 27, 2016

Exception for example:

"Could not load assembly PushSharp.Apple, Version=1.0.5858.36879, Culture=neutral, PublicKeyToken=null' או . A strongly-named assembly is required."strong named

@MosheL
Copy link
Author

MosheL commented Jan 27, 2016

something strange.

I removed NuGet package and signed DLL.s

test application with nuget original - works.
with signed files I reciveing this exception (translated to JSON)

{"ClassName":"System.AggregateException",
"Message":"אירעה שגיאה אחת או יותר." // one or more errors
,"Data":{},"InnerException":{"NativeErrorCode":-2146893043
,"ClassName":"System.ComponentModel.Win32Exception","Message":"The credentials supplied to the package were not recognized","Data":{},"InnerException":null,"HelpURL":null,"StackTraceString":"   ב-  PushSharp.Apple.ApnsServiceConnection.<Send>d__2.MoveNext()","RemoteStackTraceString":null,"RemoteStackIndex":0,"ExceptionMethod":"8\nMoveNext\nPushSharp.Apple, Version=1.0.5858.36879, Culture=neutral, PublicKeyToken=bbebc209884a90f1\nPushSharp.Apple.ApnsServiceConnection+<Send>d__2\nVoid MoveNext()","HResult":-2147467259,
"Source":"PushSharp.Apple","WatsonBuckets":null},
"HResult":-2146233088,"Source":null,"WatsonBuckets":null,"InnerExceptions":[{"NativeErrorCode":-2146893043,"ClassName":"System.ComponentModel.Win32Exception","Message":"The credentials supplied to the package were not recognized","Data":{},"InnerException":null,"HelpURL":null,"StackTraceString":"   ב-  PushSharp.Apple.ApnsServiceConnection.<Send>d__2.MoveNext()","RemoteStackTraceString":null,"RemoteStackIndex":0,"ExceptionMethod":"8\nMoveNext\nPushSharp.Apple, Version=1.0.5858.36879, Culture=neutral, PublicKeyToken=bbebc209884a90f1\nPushSharp.Apple.ApnsServiceConnection+<Send>d__2\nVoid MoveNext()","HResult":-2147467259,"Source":"PushSharp.Apple","WatsonBuckets":null}]}

@Redth
Copy link
Owner

Redth commented Mar 1, 2016

Not sure why strong namer isn't working for you, but I'm going to confirm I do not intend to sign PushSharp 3.

@Redth Redth closed this as completed Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants