Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x-webhooks support #174

Closed
adamaltman opened this issue Aug 2, 2020 · 1 comment
Closed

x-webhooks support #174

adamaltman opened this issue Aug 2, 2020 · 1 comment
Labels
Type: Bug Something isn't working

Comments

@adamaltman
Copy link
Member

Describe the bug
It seems $ref used within x-webhooks are not resolved by openapi-cli (but are by Redoc's current parser) which causes the docs to crash. OpenAPI-cli needs to resolve those $refs.

To Reproduce
Steps to reproduce the behavior:

  1. See: Define x-webhooks in API definitions Rebilly/api-definitions#156

Expected behavior
I expect openapi-cli bundle to resolve and bundle the $ref's in the x-examples section.

Logs
n/a

OpenAPI definition
See Rebilly/api-definitions#156

Version(s)
1.0.0-beta.8

Additional context
Maybe we should be able to configure $ref resolution for other specification extensions too. Maybe it should be configurable in the .redocly.yaml file?
@adamaltman adamaltman added the Type: Bug Something isn't working label Aug 2, 2020
@adamaltman adamaltman mentioned this issue Aug 7, 2020
Merged
@RomanHotsiy
Copy link
Member

Implemented in #183. Will be included in the upcoming release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adamaltman @RomanHotsiy