You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
allOf types are not rendered properly in rc.72.
Attributes like readOnly and description seem to be applied from the last item in the allOf list, and not taken from the allOf type itself.
Expected behavior
Attributes like readOnly and description should rendered properly if defined for an allOf type, and not always applied/inherited from the base type(s).
Given the specification below, billingAccountId should have been visible in the request body. All attribute descriptions should have had other values in both the request and response body.
Minimal reproducible OpenAPI snippet(if possible)
openapi: 3.0.3info:
version: 0.0.1title: Test APIservers: []tags:
- name: Orderpaths:
/orders:
summary: Product orderingpost:
tags:
- Ordersummary: Create orderdescription: | Create an orderoperationId: createProductOrderrequestBody:
$ref: "#/components/requestBodies/Order"responses:
"201":
$ref: "#/components/responses/OrderCreated"components:
schemas:
ProductOfferingId:
description: Original description for type `ProductOfferingId` which should havebeen overriddentype: stringexample: SOME_PRODUCTAccountId:
description: > Original description for type `AccountId` which should have been overridden (type with `readOnly: true`)type: stringreadOnly: trueexample: "123456789"ProductOrder:
description: | Represents an ordertype: objectproperties:
offeringId:
description: | Overidden description for `offeringId`allOf:
- $ref: "#/components/schemas/ProductOfferingId"billingAccountId:
description: > Overridden description for `billingAccountId` (type with `readOnly: false`)readOnly: falseallOf:
- $ref: "#/components/schemas/AccountId"requestBodies:
Order:
required: truecontent:
application/json:
schema:
$ref: "#/components/schemas/ProductOrder"responses:
OrderCreated:
description: Createdcontent:
application/json:
schema:
$ref: "#/components/schemas/ProductOrder"
Screenshots
Rendered as expected in RC 59.
Error in RC 72. billingAccountId not visible in the request body. All descriptions are wrong.
Additional context
Not sure exactly which version the bug was introduced in. I'm sure it works properly in some later versions than rc59 as well.
The specification is rendered correctly in 42crunch openapi editor and in the Redocly openAPI plugin for VisualCode.
The text was updated successfully, but these errors were encountered:
Describe the bug
allOf types are not rendered properly in rc.72.
Attributes like
readOnly
anddescription
seem to be applied from the last item in the allOf list, and not taken from the allOf type itself.Expected behavior
Attributes like readOnly and description should rendered properly if defined for an allOf type, and not always applied/inherited from the base type(s).
Given the specification below,
billingAccountId
should have been visible in the request body. All attributedescriptions
should have had other values in both the request and response body.Minimal reproducible OpenAPI snippet(if possible)
Screenshots
Rendered as expected in RC 59.
Error in RC 72.
billingAccountId
not visible in the request body. Alldescriptions
are wrong.Additional context
Not sure exactly which version the bug was introduced in. I'm sure it works properly in some later versions than rc59 as well.
The specification is rendered correctly in 42crunch openapi editor and in the Redocly openAPI plugin for VisualCode.
The text was updated successfully, but these errors were encountered: