Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: merge allOf in correct order #2020

Merged
merged 1 commit into from
May 26, 2022

Conversation

AlexVarchuk
Copy link
Collaborator

@AlexVarchuk AlexVarchuk commented May 23, 2022

What/Why/How?

after releasing the conditional operators we have a problem with merging oneOf, anyOf, and other parts of the schema.

fixes #2017

Reference

Testing

Screenshots (optional)

Screenshot 2022-05-23 at 15 32 44

Check yourself

  • Code is linted
  • Tested
  • All new/updated code is covered with tests

@AlexVarchuk AlexVarchuk self-assigned this May 23, 2022
@AlexVarchuk AlexVarchuk requested a review from RomanHotsiy May 23, 2022 11:25
@AlexVarchuk AlexVarchuk force-pushed the fix/oneOf-after-conditional-operators branch from 2ac8671 to 6583554 Compare May 23, 2022 12:30
@AlexVarchuk AlexVarchuk marked this pull request as ready for review May 23, 2022 12:35
@AlexVarchuk AlexVarchuk requested a review from a team as a code owner May 23, 2022 12:35
@AlexVarchuk AlexVarchuk requested review from zalesky and anastasiia-developer and removed request for a team May 23, 2022 12:35
src/services/OpenAPIParser.ts Outdated Show resolved Hide resolved
src/services/OpenAPIParser.ts Outdated Show resolved Hide resolved
src/services/OpenAPIParser.ts Outdated Show resolved Hide resolved
@AlexVarchuk AlexVarchuk requested a review from RomanHotsiy May 23, 2022 16:22
@AlexVarchuk AlexVarchuk force-pushed the fix/oneOf-after-conditional-operators branch from 79d7f71 to 94e7d13 Compare May 26, 2022 11:46
@AlexVarchuk AlexVarchuk force-pushed the fix/oneOf-after-conditional-operators branch from 94e7d13 to 1f8caa6 Compare May 26, 2022 11:47
@AlexVarchuk AlexVarchuk merged commit 1e4ea03 into master May 26, 2022
@AlexVarchuk AlexVarchuk deleted the fix/oneOf-after-conditional-operators branch May 26, 2022 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lost functionality over weekend (worked on Friday) oneOf names not working and lost drop examples
4 participants