Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: theme add sidebar activeBackgroundColor and activeTextColor #1600

Merged
merged 3 commits into from
Apr 7, 2022
Merged

feat: theme add sidebar activeBackgroundColor and activeTextColor #1600

merged 3 commits into from
Apr 7, 2022

Conversation

imagoiq
Copy link
Contributor

@imagoiq imagoiq commented Apr 30, 2021

  • Add activeBackgroundColor and activeTextColor to groupItems and level1Items
  • Leave general activeTextColor for all sidebar for compatibility
  • Rename menu to sidebar in readme

@RomanHotsiy RomanHotsiy added this to the v2.0 milestone Mar 22, 2022
@AlexVarchuk AlexVarchuk requested review from Oprysk and zalesky April 6, 2022 13:14
@anastasiia-developer
Copy link
Contributor

Before
Setting the background and text color for the active (selected) is not available

Screenshot 2022-04-07 at 12 46 06

After
Setting the background and text color for the active (selected) is available
the active color for the title and sub-item is customizable
Screenshot 2022-04-07 at 12 46 38

@anastasiia-developer @zalesky
Update src/components/SideMenu/styled.elements.ts
963fc06 
Co-authored-by: Andriy Zaleskyy <zal3sky@gmail.com>
@anastasiia-developer
Copy link
Contributor

@imagoiq Hi! Sorry for the huge delay. Thank you for your contribution to redoc.

@anastasiia-developer anastasiia-developer merged commit 6716b08 into Redocly:master Apr 7, 2022
@anastasiia-developer anastasiia-developer mentioned this pull request Apr 8, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oprysk Oprysk Oprysk approved these changes

@zalesky zalesky zalesky approved these changes

@AlexVarchuk AlexVarchuk AlexVarchuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.
6 participants
@imagoiq @anastasiia-developer @AlexVarchuk @zalesky @Oprysk @RomanHotsiy