fix: Path parameters are not correctly overriden

fixes #400
Redocly · Jan 21, 2018 · c406dc5 · c406dc5
1 parent e8adb60
commit c406dc5
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/lib/utils/spec-manager.ts b/lib/utils/spec-manager.ts
@@ -163,6 +163,12 @@ export class SpecManager {
 
     let operationParamsPtr = JsonPointer.join(operationPtr, ['parameters']);
     let operationParams:SwaggerParameter[] = this.byPointer(operationParamsPtr) || [];
+
+    const operationParamNames = {};
+    operationParams.forEach(param => operationParamNames[param.name] = true);
+
+    // filter out path params overriden by operation ones with the same name
+    pathParams = pathParams.filter(pathParam => !operationParamNames[pathParam.name]);
     pathParams = injectPointers(pathParams, pathParamsPtr);
     operationParams = injectPointers(operationParams, operationParamsPtr);