fix: fix escaping JSON string values

fixes #999
Redocly · Aug 7, 2019 · 58cb20d · 58cb20d
1 parent 7849f7f
commit 58cb20d
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/utils/jsonToHtml.ts b/src/utils/jsonToHtml.ts
@@ -20,8 +20,8 @@ function htmlEncode(t) {
     : '';
 }
 
-function escapeForStringLiteral(str: string) {
-  return str.replace(/([\\"])/g, '\\$1');
+function stringifyStringLiteral(str: string) {
+  return JSON.stringify(str).slice(1, -1);
 }
 
 function decorateWithSpan(value, className) {
@@ -56,11 +56,11 @@ function valueToHTML(value, maxExpandLevel: number) {
         '<a href="' +
         value +
         '">' +
-        htmlEncode(escapeForStringLiteral(value)) +
+        htmlEncode(stringifyStringLiteral(value)) +
         '</a>' +
         decorateWithSpan('"', 'token string');
     } else {
-      output += decorateWithSpan('"' + escapeForStringLiteral(value) + '"', 'token string');
+      output += decorateWithSpan('"' + stringifyStringLiteral(value) + '"', 'token string');
     }
   } else if (valueType === 'boolean') {
     output += decorateWithSpan(value, 'token boolean');