Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prepare 2.0 release #102

Closed
wants to merge 6 commits into from
Closed

prepare 2.0 release #102

wants to merge 6 commits into from

Conversation

gkorland
Copy link
Contributor

@gkorland gkorland commented Oct 22, 2020 •
edited
Loading

fix #110
fix #24

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Oct 22, 2020 •
edited
Loading

Codecov Report

Merging #102 (d4e23b4) into master (5aa42a6) will increase coverage by 4.57%.
The diff coverage is n/a.

❗ Current head d4e23b4 differs from pull request most recent head a1d32b3. Consider uploading reports for the commit a1d32b3 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
+ Coverage   85.59%   90.17%   +4.57%     
==========================================
  Files          12       12              
  Lines        1701     1700       -1     
==========================================
+ Hits         1456     1533      +77     
+ Misses        245      167      -78
Impacted Files Coverage Δ
redisearch/__init__.py 100.00% <0.00%> (ø)
redisearch/auto_complete.py 93.24% <0.00%> (ø)
redisearch/client.py 85.62% <0.00%> (+7.40%) ⬆️
test/test.py 96.01% <0.00%> (+8.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5aa42a6...a1d32b3. Read the comment docs.

MeirShpilraien
MeirShpilraien reviewed Oct 22, 2020
View reviewed changes
requirements.txt Outdated
@@ -1,4 +1,4 @@
hiredis>=0.2.0
redis>=2.10
rmtest>=0.2
rmtest>=0.7.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rmtest is for testing only no? Does it needed as a requirement?

MeirShpilraien
MeirShpilraien reviewed Oct 22, 2020
View reviewed changes
Copy link

@MeirShpilraien MeirShpilraien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small question..

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@abrookins
Copy link
Contributor

@gkorland Can we get this PR merged? If you have development dependencies, the usual approach is to include a second file, requirements-dev.txt, with just those.

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 6, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@gkorland gkorland closed this May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MeirShpilraien MeirShpilraien MeirShpilraien left review comments

@ashtul ashtul Awaiting requested review from ashtul

@rafie rafie Awaiting requested review from rafie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python 3 support? Is the 2.0 version compatible with redis-py 3.x ?
3 participants
@gkorland @abrookins @MeirShpilraien