refactor: clean up notification related code

Author: ZanzyTHEbar

GUI/ETVR/src/components/Notifications/CustomToast/index.tsx

@@ -35,8 +35,6 @@ const CustomToast: Component<ToastProps> = (props) => {
             }}>
             <Toast class="flex justify-between items-center">
                 <Alert class="bg-slate-600 flex grow flex-row items-center justify-center text-xl text-bold text-gray-50 p-4">
-                    {/* TODO: Refactor this so that the rendered type is local to the notification itself */}
-                    {/* Note: This will change all rendered notifications to the type when matched - this is bad. */}
                     <div>
                         <Show when={props.notif.type === ENotificationType.SUCCESS}>
                             <AiOutlineCheckCircle size={25} color="#68D391" />

GUI/ETVR/src/store/ui/selectors.ts

@@ -8,6 +8,4 @@ export const menuOpenStatus = createMemo(() => uiState().menuOpen)
 export const connectedUserName = createMemo(() => uiState().connectedUser)
 export const showCameraView = createMemo(() => uiState().showCameraView)
 export const notifications = createMemo(() => uiState().notifications)
-//export const notificationsType = createMemo(() => uiState().notificationsType)
 export const hideHeaderButtons = createMemo(() => uiState().hideHeaderButtons)
-export const progressBar = createMemo(() => uiState().progressBar)

GUI/ETVR/src/store/ui/ui.ts

@@ -36,7 +36,6 @@ export interface IUiStore {
     connectedUser: string
     notifications?: ToasterStore<INotifications>
     hideHeaderButtons: boolean
-    progressBar?: IProgressBar
 }
 
 export const defaultState = {
@@ -108,12 +107,4 @@ export const setShowCameraView = (showCameraView: boolean) => {
     )
 }
 
-export const setProgressBar = (progress: number, msg: string, show: boolean) => {
-    setState(
-        produce((s) => {
-            s.progressBar = { progress, msg, show }
-        }),
-    )
-}
-
 export const uiState = createMemo(() => state)

GUI/ETVR/src/utils/hooks/notifications/index.ts

@@ -18,11 +18,10 @@ export const notify = (title: string, body: string | undefined) => {
 /**
  * Send notification to the OS or to the WebView Window using a custom API
  * @param {INotifications} notification Notification message
- * @param {ENotificationAction} actionType Notification action type
  */
 export const addNotification = (notification: INotifications) => {
     const { title, message, action } = notification
-    const notificationAction = NotificationsType(action, {
+    NotificationType(action, {
         callbackOS: () => {
             sendNotification({
                 title,
@@ -34,10 +33,9 @@ export const addNotification = (notification: INotifications) => {
             notifications()?.create(notification)
         },
     })
-    return notificationAction
 }
 
-export const NotificationsType = (
+const NotificationType = (
     notificationAction: ENotificationAction,
     { callbackOS, callbackApp }: INotificationAction,
 ) => {