Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid ClassNotFoundException #61

Merged
merged 4 commits into from
Apr 5, 2023
Merged

Avoid ClassNotFoundException #61

merged 4 commits into from
Apr 5, 2023

Conversation

jponge
Copy link
Collaborator

@jponge jponge commented Apr 3, 2023

wildfly-elytron-x500-cert has a dependency on jboss-logging.

mocenas and others added 2 commits April 3, 2023 14:05
@mocenas
Test to fail with: https://issues.redhat.com/browse/MWTELE-55
b43c476
@jponge
Fix for MWTELE-55
5ec22bf 
We have to avoid the jboss-logging exclusion from wildfly-elytron-x500-cert,
otherwise we can have a class not found exception.
@jponge jponge added this to the 1.0.0 milestone Apr 3, 2023
@jponge jponge added the bug Something isn't working label Apr 3, 2023
@mocenas
Copy link
Contributor

mocenas commented Apr 3, 2023

LGTM

kittylyst
kittylyst approved these changes Apr 5, 2023
View reviewed changes
Copy link
Collaborator

@kittylyst kittylyst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 🚢

@jponge jponge merged commit 1440e30 into main Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsavoie ehsavoie ehsavoie approved these changes

@kittylyst kittylyst kittylyst approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jponge @mocenas @ehsavoie @kittylyst