React Rewrite: A couple minor bug fixes #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrBlenny
changed the title
RomanHotsiy
requested changes
Mar 14, 2018
demo/index.tsx
Outdated
| @@ -24,7 +24,7 @@ const DEFAULT_SPEC = 'openapi.yaml'; | |||
| class DemoApp extends React.Component< | |||
| {}, | |||
| { specUrl: string; dropdownOpen: boolean; cors: boolean } | |||
| > { | |||
| > { | |||
There was a problem hiding this comment.
could you please remove space here
RomanHotsiy
approved these changes
Mar 14, 2018
|
Nice 👍 |
|
fyi, you still don't appear on Contributors page but you will once I merge this branch into master. GitHub doesn't count contributions to non-default branches. |
|
All good. Would be wonderful if you could publish another alpha to npm :) |
|
released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if (schema.allOf === undefined) {