Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text on marble diagrams have some ugly artifacts #7089

Closed
tyilo opened this issue Oct 18, 2022 · 1 comment
Closed

Text on marble diagrams have some ugly artifacts #7089

tyilo opened this issue Oct 18, 2022 · 1 comment

Comments

@tyilo
Copy link

tyilo commented Oct 18, 2022

Describe the bug

Text on all marble diagrams on the https://rxjs.dev/ website doesn't look very nice as there are some artifacts below most letters.

Example from https://rxjs.dev/api/index/function/takeUntil:

Zoomed in:
image

Expected behavior

The text should not have these weird artifacts.

Reproduction code

No response

Reproduction URL

No response

Version

7.5.7

Environment

No response

Additional context

No response

@jakovljevic-mladen
Copy link
Member

Hey @tyilo, thanks for reporting this. We are aware of this issue and we would like to update every marble diagram we have in the repository, but this is something that requires quite a lot of effort. If you have enough time, feel free to open PRs to update these images. We now have a new and better way of creating marble diagram images. For the reference, I'm gonna post a couple of PRs here to check how to do it: #6636 #6742 #6638 #6983

Also, I'm gonna close this issue since GitHub issues are intended to be used for bugs in the library core. If needed, we can open a new discussion where we could write (and track progress) of all marble diagram images that need to be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants