Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename all operators that are duplicates of static operators to xWith variants #3927

Closed
benlesh opened this issue Jul 16, 2018 · 9 comments
Closed

Comments

@benlesh
Copy link
Member

benlesh commented Jul 16, 2018

concat -> concatWith
zip -> zipWith
merge -> mergeWith

etc.

Related #3798

@benlesh benlesh added type: discussion AGENDA ITEM Flagged for discussion at core team meetings labels Jul 16, 2018
@benlesh
Copy link
Member Author

benlesh commented Jul 16, 2018

The plan here, of course, is to add aliases and deprecations in the short term.

@SanderElias
Copy link

Go for it, one thing less that can cause confusion. While at this, can you make it so that (Not sure this is possible at all) the old operators can't be found anymore by the auto-import tools in editors?
Every now and then I lose a bit of time because my auto-import tool imported the wrong thing.

@benlesh benlesh removed the AGENDA ITEM Flagged for discussion at core team meetings label Aug 1, 2018
@Pappa
Copy link

Pappa commented Sep 10, 2018

I ran into this over the weekend, and spent several hours trying to work out why concat wasn't working as expected when I was inadvertently importing the rxjs/operators one. Semantically, I think using ...With is clearer too.

@jgbpercy
Copy link

jgbpercy commented Feb 6, 2019

As someone that spends a fair bit of time introducing people to rxjs, this is an early pain point. While the two import locations make sense once you're experienced, it's something that seems really arbitrary early on, and the type errors you get from it are not helpful or enlightening to beginners. And even for experienced users it degrades the editor experience... Would be awesome to see fixed in v7!

@martinsik
Copy link
Contributor

I think renaming them is a good idea because this confusion keeps popping on StackOverflow regularly and from the error it throws it's not obvious what you're doing wrong.

@martinsik
Copy link
Contributor

I'm now thinking if when some static operators like merge are marked as deprecated does this issue mean that they won't be deprecated and just renamed?

@BioPhoton
Copy link
Contributor

@benlesh
Is the renaming still a thing? I really really hope so!!!!

@BioPhoton
Copy link
Contributor

Following things should be considered:

  • combineLatest, merge, concat, zip got deprecated in version 6.0.0-rc.0 and should be removed
  • race got deprecated in version 6.2.0 and should be removed

@cartant
Copy link
Collaborator

cartant commented Mar 13, 2021

Closing this because it has been done - except for onErrorResumeNext which is going to be removed entirely.

@cartant cartant closed this as completed Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants