Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skipUntil - v6.1.0 - throws an exception 'unsubscribe' of undefined #3685

Closed
claylaut opened this issue May 11, 2018 · 0 comments
Closed

skipUntil - v6.1.0 - throws an exception 'unsubscribe' of undefined #3685

claylaut opened this issue May 11, 2018 · 0 comments

Comments

@claylaut
Copy link
Contributor

claylaut commented May 11, 2018 •
edited
Loading

RxJS version: 6.1.0 / 6.0.0 (tested on both)

Code to reproduce:
https://stackblitz.com/edit/rxjs-skipuntil-issue

Expected behaviour:
it should work without throwing an exception

Actual behaviour:
Throwing an exception:
Error in rxjs@6.1.0/internal/operators/skipUntil.js (60:32)
Cannot read property 'unsubscribe' of undefined

Additional information:
This issue is related to this change:
https://github.com/ReactiveX/rxjs/pull/3512/files#diff-fb87e1b2c0661f48fca4bf43fb5a19a3R60

PR including Fix
#3686

This works perfectly in 5.5.10 and lower versions.
@claylaut claylaut mentioned this issue May 11, 2018
Merged
@benlesh benlesh closed this as completed May 21, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jun 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benlesh @claylaut