Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIGRATION.md and RxJS API #2057

Closed
Pappa opened this issue Oct 21, 2016 · 7 comments
Closed

MIGRATION.md and RxJS API #2057

Pappa opened this issue Oct 21, 2016 · 7 comments
Assignees

Comments

@Pappa
Copy link

Pappa commented Oct 21, 2016

I recently opened a pull request for the some operator and was confronted with a discussion about whether the operator should be included. As a new contributor, hoping to give some time to the project, I find the guidance on operator inclusion confusing.

The MIGRATION.md document states that there are many operator that are "Not yet implemented", suggesting that the project would like contributors to implement them. I haven't found any kind of discussion on what should/shouldn't be included in the API. I don't know if this discussion has happened, but not been published anywhere easily accessible, or only occurs in pull request discussions.

I'd like to contribute more to RxJS development, but I think there needs to be more clarity on what contributions are needed/wanted for the API. Currently that's really not obvious from the documentation available.

@kwonoj
Copy link
Member

kwonoj commented Oct 21, 2016

Yes, it is bit unclear in those document. Primary reason for those is discussion for finalizing api surface for v5 has just started recently, and for each individual operator it need to be discussed per each use cases. Sometimes it seems not needed operator but there is possible usecase couldn't think of, and sometimes proposal for operator can be achieved easily with current operators.

General goal for v5 is settle down api surface and do not extend more unless there is significant usecases, and discuss over next release after make v5 public release out of beta. There will be periodic discussion and meeting notes will be published as well clear several topics.

It is great appreciate for existing PR's effort and further effort for contribution. If something's unclear in current documentation and need clarification, feel freely open issue anytime first. Then you can bring it as following PR by its conclusion.

@jayphelps
Copy link
Member

@Pappa agreed! We're all learning and improving this process as we go, please forgive our lack of transparency but do continue to hold us accountable.

I'd echo what @kwonoj said as well.

@Pappa
Copy link
Author

Pappa commented Oct 24, 2016

Thanks for the feedback.

@kwonoj
Copy link
Member

kwonoj commented Oct 25, 2016

@Pappa , I hope question is answered, let me close issue for now. Please feel freely reopen if there's remaining issue.

@kwonoj kwonoj closed this as completed Oct 25, 2016
@jayphelps
Copy link
Member

I wanna keep this open for my reference to make the MIGRATION doc more clear in many ways.

@jayphelps jayphelps reopened this Oct 25, 2016
@jayphelps jayphelps self-assigned this Oct 25, 2016
@benlesh
Copy link
Member

benlesh commented Jan 25, 2018

Closing as stale.

@benlesh benlesh closed this as completed Jan 25, 2018
@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants