-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MIGRATION.md and RxJS API #2057
Comments
Yes, it is bit unclear in those document. Primary reason for those is discussion for finalizing api surface for v5 has just started recently, and for each individual operator it need to be discussed per each use cases. Sometimes it seems not needed operator but there is possible usecase couldn't think of, and sometimes proposal for operator can be achieved easily with current operators. General goal for v5 is settle down api surface and do not extend more unless there is significant usecases, and discuss over next release after make v5 public release out of beta. There will be periodic discussion and meeting notes will be published as well clear several topics. It is great appreciate for existing PR's effort and further effort for contribution. If something's unclear in current documentation and need clarification, feel freely open issue anytime first. Then you can bring it as following PR by its conclusion. |
Thanks for the feedback. |
@Pappa , I hope question is answered, let me close issue for now. Please feel freely reopen if there's remaining issue. |
I wanna keep this open for my reference to make the MIGRATION doc more clear in many ways. |
Closing as stale. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
I recently opened a pull request for the
some
operator and was confronted with a discussion about whether the operator should be included. As a new contributor, hoping to give some time to the project, I find the guidance on operator inclusion confusing.The MIGRATION.md document states that there are many operator that are "Not yet implemented", suggesting that the project would like contributors to implement them. I haven't found any kind of discussion on what should/shouldn't be included in the API. I don't know if this discussion has happened, but not been published anywhere easily accessible, or only occurs in pull request discussions.
I'd like to contribute more to RxJS development, but I think there needs to be more clarity on what contributions are needed/wanted for the API. Currently that's really not obvious from the documentation available.
The text was updated successfully, but these errors were encountered: