From 83533d13103b0dfeec85862812b491506cbbc6ae Mon Sep 17 00:00:00 2001 From: Dkosasih Date: Thu, 11 Oct 2018 09:03:01 +1100 Subject: [PATCH] fix(endWith): ability to endWith different types (#4183) (#4185) --- spec-dtslint/operators/endWith-spec.ts | 8 ++++---- src/internal/operators/endWith.ts | 16 ++++++++-------- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/spec-dtslint/operators/endWith-spec.ts b/spec-dtslint/operators/endWith-spec.ts index 3bfa1b3fd2..8f4d3aaa2c 100644 --- a/spec-dtslint/operators/endWith-spec.ts +++ b/spec-dtslint/operators/endWith-spec.ts @@ -33,10 +33,10 @@ it('should infer type for rest parameters', () => { const a = of(1, 2, 3).pipe(endWith(4, 5, 6, 7, 8, 9, 10)); // $ExpectType Observable }); -it('should accept empty parameter', () => { - const a = of(1, 2, 3).pipe(endWith()); // $ExpectType Observable +it('should infer with different types', () => { + const a = of(1, 2, 3).pipe(endWith('4', true)); // $ExpectType Observable }); -it('should enforce type', () => { - const a = of(1, 2, 3).pipe(endWith('4')); // $ExpectError +it('should accept empty parameter', () => { + const a = of(1, 2, 3).pipe(endWith()); // $ExpectType Observable }); diff --git a/src/internal/operators/endWith.ts b/src/internal/operators/endWith.ts index 827118156a..1ed4ee4ec8 100644 --- a/src/internal/operators/endWith.ts +++ b/src/internal/operators/endWith.ts @@ -4,17 +4,17 @@ import { scalar } from '../observable/scalar'; import { empty } from '../observable/empty'; import { concat as concatStatic } from '../observable/concat'; import { isScheduler } from '../util/isScheduler'; -import { MonoTypeOperatorFunction, SchedulerLike } from '../types'; +import { MonoTypeOperatorFunction, SchedulerLike, OperatorFunction } from '../types'; /* tslint:disable:max-line-length */ export function endWith(scheduler?: SchedulerLike): MonoTypeOperatorFunction; -export function endWith(v1: T, scheduler?: SchedulerLike): MonoTypeOperatorFunction; -export function endWith(v1: T, v2: T, scheduler?: SchedulerLike): MonoTypeOperatorFunction; -export function endWith(v1: T, v2: T, v3: T, scheduler?: SchedulerLike): MonoTypeOperatorFunction; -export function endWith(v1: T, v2: T, v3: T, v4: T, scheduler?: SchedulerLike): MonoTypeOperatorFunction; -export function endWith(v1: T, v2: T, v3: T, v4: T, v5: T, scheduler?: SchedulerLike): MonoTypeOperatorFunction; -export function endWith(v1: T, v2: T, v3: T, v4: T, v5: T, v6: T, scheduler?: SchedulerLike): MonoTypeOperatorFunction; -export function endWith(...array: Array): MonoTypeOperatorFunction; +export function endWith(v1: A, scheduler?: SchedulerLike): OperatorFunction; +export function endWith(v1: A, v2: B, scheduler?: SchedulerLike): OperatorFunction; +export function endWith(v1: A, v2: B, v3: C, scheduler?: SchedulerLike): OperatorFunction; +export function endWith(v1: A, v2: B, v3: C, v4: D, scheduler?: SchedulerLike): OperatorFunction; +export function endWith(v1: A, v2: B, v3: C, v4: D, v5: E, scheduler?: SchedulerLike): OperatorFunction; +export function endWith(v1: A, v2: B, v3: C, v4: D, v5: E, v6: F, scheduler?: SchedulerLike): OperatorFunction; +export function endWith(...array: Array): OperatorFunction; /* tslint:enable:max-line-length */ /**