Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zip with iterable, removed old aggregator version and updated tests #741

Merged
merged 1 commit into from
Jan 14, 2014

Conversation

akarnokd
Copy link
Member

Listed in #653.

@akarnokd akarnokd mentioned this pull request Jan 11, 2014
25 tasks
@cloudbees-pull-request-builder

RxJava-pull-requests #656 SUCCESS
This pull request looks good

@benjchristensen
Copy link
Member

These are instance methods, none of our zip operators are at the instance level. I would have thought we'd add the zip overloads with Iterable to match the existing static ones?

@akarnokd
Copy link
Member Author

I went according to #653 where there was 2 zip overloads without strike-through.

@benjchristensen
Copy link
Member

Agreed on the overloads, but they should be static, correct?

@akarnokd
Copy link
Member Author

No. The intention was to chain them to an existing observable:

Observable.from(1, 2, 3).zip(Arrays.asList(4, 5, 6), (a, b) -> a * b);

@benjchristensen
Copy link
Member

Makes sense, wasn't sure as it was different than all the other zip methods.

Thanks for confirming.

benjchristensen added a commit that referenced this pull request Jan 14, 2014
Zip with iterable, removed old aggregator version and updated tests
@benjchristensen benjchristensen merged commit 52db70c into ReactiveX:master Jan 14, 2014
@akarnokd akarnokd deleted the ZipInstanceMethods branch May 6, 2014 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants