Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Error Handling and Stacktraces When Unsubscribe Fails #730

Merged
merged 1 commit into from
Jan 9, 2014
Merged

Improve Error Handling and Stacktraces When Unsubscribe Fails #730

merged 1 commit into from
Jan 9, 2014
+433 −57

Commits on Jan 9, 2014

  1. Improve Error Handling and Stacktraces 

    The stacktraces were a mess when onError failed or was not implemented and unsubscribe also failed.
That is a far edge case and means code is broken and breaking the Rx contracts … but that’s just when we need clear stacktraces.
The CompositeException and SafeObserver class now do a dance and wire together a causal chain to provide a stacktrace that can identity all the points of error.
Also standardized and simplified the RxJavaPlugin.onErrorHandler while working in the vicinity.

This came about after I was asked to help debug a problem and couldn’t do it by looking at the thrown exception, I had to use a debugger and step through.
    @benjchristensen
    benjchristensen committed Jan 9, 2014
    Configuration menu
    Copy the full SHA
    8e6bef3 View commit details
    Browse the repository at this point in the history