-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Scheduler Memory Leaks #712
Fix Scheduler Memory Leaks #712
Commits on Dec 31, 2013
-
Configuration menu - View commit details
-
Copy full SHA for 93d4e69 - Browse repository at this point
Copy the full SHA 93d4e69View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0977f04 - Browse repository at this point
Copy the full SHA 0977f04View commit details -
NewThreadScheduler is working, the other two are not so commented out for now until fixed.
Configuration menu - View commit details
-
Copy full SHA for fdbf5ef - Browse repository at this point
Copy the full SHA fdbf5efView commit details -
Fix Memory Leak in NewThreadScheduler Recursion
- the Action0 method did not have a leak - the Func2 method on inner scheduler recursion did have a leak
Configuration menu - View commit details
-
Copy full SHA for b1d9c1c - Browse repository at this point
Copy the full SHA b1d9c1cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f35594 - Browse repository at this point
Copy the full SHA 9f35594View commit details -
ExecutorScheduler Memory Leak Fix
- new InnerExecutorScheduler and childSubscription - improvements to unit tests
Configuration menu - View commit details
-
Copy full SHA for 5b2dab3 - Browse repository at this point
Copy the full SHA 5b2dab3View commit details -
CurrentThreadScheduler Memory Leak Fixed
- Current/Immediate/NewThread/Executor Schedulers are passing unit tests - Current/NewThread/Executor Schedulers do not leak memory on the recursion test (Immediate can’t be used for recursion otherwise it stack overflows)
Configuration menu - View commit details
-
Copy full SHA for 9a94fd2 - Browse repository at this point
Copy the full SHA 9a94fd2View commit details -
- use Long instead of Int so we don’t overflow - migrate from deprecated method
Configuration menu - View commit details
-
Copy full SHA for 28dd5fc - Browse repository at this point
Copy the full SHA 28dd5fcView commit details -
- outer/inner scheduling so nested order is correct while not deadlocking on certain nested use cases as found in previous testing
Configuration menu - View commit details
-
Copy full SHA for 43e3d77 - Browse repository at this point
Copy the full SHA 43e3d77View commit details -
Fix CurrentThreadScheduler Delay Bug
- introduced a bug during refactor, caught it while updating unit tests
Configuration menu - View commit details
-
Copy full SHA for 2c3db73 - Browse repository at this point
Copy the full SHA 2c3db73View commit details -
- merged all scheduler tests into the same package - using inheritance so that the same tests are applied to each of the different Scheduler implementations - manual test (too slow for normal execution) can be run to test memory leaks (TestRecursionMemoryUsage.java)
Configuration menu - View commit details
-
Copy full SHA for 1f7d6dc - Browse repository at this point
Copy the full SHA 1f7d6dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for b7e6410 - Browse repository at this point
Copy the full SHA b7e6410View commit details
Commits on Jan 2, 2014
-
Increasing Unit Test Timeout for Slow Machines
- Increasing timeout by a lot to handle slow machines such as this: https://netflixoss.ci.cloudbees.com/job/RxJava-pull-requests/629/testReport/junit/rx.schedulers/ExecutorSchedulerTests/recursionUsingFunc2/ - The timeout is only there if a deadlock or memory leak occurs (which is what this PR is fixing) so when everything is healthy it does not timeout
Configuration menu - View commit details
-
Copy full SHA for abe9c98 - Browse repository at this point
Copy the full SHA abe9c98View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9b3a838 - Browse repository at this point
Copy the full SHA 9b3a838View commit details -
- this test does a flatMap which uses merge which has non-deterministic ordering since the Observable.from can be on a new thread each time
Configuration menu - View commit details
-
Copy full SHA for 1d0d90c - Browse repository at this point
Copy the full SHA 1d0d90cView commit details