Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operators BO.chunkify, BO.collect, O.forIterable #636

Closed

Conversation

akarnokd
Copy link
Member

Issue #634

Any suggestions for a name instead of forIterable?

@cloudbees-pull-request-builder

RxJava-pull-requests #566 SUCCESS
This pull request looks good

@zsxwing zsxwing mentioned this pull request Dec 20, 2013
53 tasks
* @return an Observable which concatenates the observable sequences obtained by running the
* resultSelector for each element in the given Iterable source.
*/
public static <T, R> Observable<R> forIterable(Iterable<? extends T> source, Func1<? super T, ? extends Observable<? extends R>> resultSelector) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the use case for this? I'm not understanding the need for this signature.

We can already create an Observable out of an Iterable and then perform the many different operators on it.

What does this relate to on the Rx.Net side?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is called For in Rx.NET. It behaves differently from the regular iterable as it iterates to the next value only when the previous one's selected Observable completes. For example, if source is large or infinite, it won't try to read through it completely like concat does.

This was referenced Dec 23, 2013
@akarnokd
Copy link
Member Author

Split into two.

@akarnokd akarnokd closed this Dec 24, 2013
@akarnokd akarnokd deleted the OperationCollectChunkifyFor branch January 13, 2014 09:59
jihoonson pushed a commit to jihoonson/RxJava that referenced this pull request Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants