Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented the 'Amb' operator #460

Merged
merged 2 commits into from
Nov 5, 2013
Merged

Conversation

zsxwing
Copy link
Member

@zsxwing zsxwing commented Nov 1, 2013

Hi, this PR implemented the Amb operator #22. I used varargs to support the array version and first-second version in one method. So in my PR, there are only two variants.

@cloudbees-pull-request-builder

RxJava-pull-requests #379 FAILURE
Looks like there's a problem with this pull request

@samuelgruetter
Copy link
Contributor

You shouldn't define a vararg method taking a generic type, because you cannot use it without getting warnings (we've already had this with other operators). Instead, define an overload for 2 args, 3 args, 4 args, ...

@benjchristensen
Copy link
Member

Yup, it's a pain, but this is what we ended up doing for zip, merge, etc instead of using varargs.

@cloudbees-pull-request-builder

RxJava-pull-requests #382 FAILURE
Looks like there's a problem with this pull request

benjchristensen added a commit that referenced this pull request Nov 5, 2013
@benjchristensen benjchristensen merged commit 50b04ec into ReactiveX:master Nov 5, 2013
@benjchristensen
Copy link
Member

Thank you

@zsxwing zsxwing deleted the amb branch November 5, 2013 05:16
rickbw pushed a commit to rickbw/RxJava that referenced this pull request Jan 9, 2014
benjchristensen added a commit to ReactiveX/RxScala that referenced this pull request Aug 19, 2014
benjchristensen added a commit to ReactiveX/RxScala that referenced this pull request Aug 19, 2014
jihoonson pushed a commit to jihoonson/RxJava that referenced this pull request Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants