Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update counter before triggering latch #411

Merged
merged 1 commit into from
Oct 9, 2013

Conversation

petermd
Copy link
Contributor

@petermd petermd commented Sep 26, 2013

as mentioned in #383

rx.concurrency.TestSchedulers.testSchedulingWithDueTime

is flaky because there is a race-condition where the test can assert the counter value before it is updated. fix is just to update the counter before releasing the latch.

@cloudbees-pull-request-builder

RxJava-pull-requests #317 SUCCESS
This pull request looks good

@benjchristensen
Copy link
Member

Thank you!

benjchristensen added a commit that referenced this pull request Oct 9, 2013
update counter before triggering latch
@benjchristensen benjchristensen merged commit b905312 into ReactiveX:master Oct 9, 2013
@petermd petermd deleted the fix-schedtests branch October 14, 2013 10:49
rickbw pushed a commit to rickbw/RxJava that referenced this pull request Jan 9, 2014
update counter before triggering latch
jihoonson pushed a commit to jihoonson/RxJava that referenced this pull request Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants