Add missing methods to Scala Adaptor #396
Merged
+1,000
−278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and try to make Olympics groupBy work with timing, but did not work due to problems with RxJava groupBy, see pull ReactiveX#289
those with custom equality are not yet there because of issue ReactiveX#395
|
RxJava-pull-requests #294 ABORTED |
|
So Jenkins needs all the 10 minutes to download |
benjchristensen
added a commit
that referenced
this pull request
Sep 21, 2013
Add missing methods to Scala Adaptor
rickbw
pushed a commit
to rickbw/RxJava
that referenced
this pull request
Jan 9, 2014
Add missing methods to Scala Adaptor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a method to the Scala Observable for each method in the Java Observable. Some were renamed, have a different signature, or were left out intentionally. A comparison can be found here.
The Scala Observable should now be complete, but there are still some TODOs.
There should be no breaking changes, but only additions.
There's also an automatic completeness test (
rx.lang.scala.CompletenessTest). If methods are missing, it still succeeds, but it prints the missing methods to stdout.