Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Count, Sum, Average implementations #354

Merged
merged 4 commits into from
Sep 9, 2013

Conversation

jmhofer
Copy link
Contributor

@jmhofer jmhofer commented Sep 7, 2013

I implemented three easy operations here simply using reduce.

Two things were tricky however:

  1. How to name the various "overloads" (have to use different names due to identical erasure). I propose sum, sumLongs, sumFloats, sumDoubles here (and the same for the averages).
  2. How to handle empty source observables when averaging. I propose throwing an ArithmeticException here.

Any other opinions?

@cloudbees-pull-request-builder

RxJava-pull-requests #245 SUCCESS
This pull request looks good

@benjchristensen
Copy link
Member

Looks good to me.

benjchristensen added a commit that referenced this pull request Sep 9, 2013
Count, Sum, Average implementations
@benjchristensen benjchristensen merged commit 2a3bb5a into ReactiveX:master Sep 9, 2013
@jmhofer jmhofer deleted the count-sum-average branch September 9, 2013 19:22
rickbw pushed a commit to rickbw/RxJava that referenced this pull request Jan 9, 2014
jihoonson pushed a commit to jihoonson/RxJava that referenced this pull request Mar 6, 2020
* Add micrometer circuit breaker metrics binder based on tags

* Add micrometer bulkhead metrics binder based on tags

* Add micrometer rate limiter metrics binder based on tags

* Add micrometer retry metrics binder based on tags

* Add micrometer async retry metrics binder based on tags

* Add documentation for tag based metrics
jihoonson pushed a commit to jihoonson/RxJava that referenced this pull request Mar 6, 2020
…tiveX#375)

* Introduce new prometheus metrics collector for bulkheads

* Introduce new prometheus metrics collector for circuit breakers

* Introduce new prometheus metrics collector for rate limiters

* Avoid label list creation on every collect

* Adapt/extend prometheus documentation

* Improve metrics descriptions
jihoonson pushed a commit to jihoonson/RxJava that referenced this pull request Mar 6, 2020
jihoonson pushed a commit to jihoonson/RxJava that referenced this pull request Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants