Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TakeUntil obey Rx serialization contract #1656

Merged
merged 1 commit into from
Sep 5, 2014

Conversation

zsxwing
Copy link
Member

@zsxwing zsxwing commented Sep 2, 2014

TakeUntil didn't synchronize messages from different Observables.

@cloudbees-pull-request-builder

ReactiveX » RxJava » RxJava-pull-requests #12 SUCCESS
This pull request looks good

@akarnokd
Copy link
Member

akarnokd commented Sep 2, 2014

The SerializedSubscriber would be a better choice here to avoid holding locks while emitting events.

@zsxwing
Copy link
Member Author

zsxwing commented Sep 2, 2014

Forgot it... Thank you.

@cloudbees-pull-request-builder

ReactiveX » RxJava » RxJava-pull-requests #13 SUCCESS
This pull request looks good

benjchristensen added a commit that referenced this pull request Sep 5, 2014
Make TakeUntil obey Rx contract
@benjchristensen benjchristensen merged commit a8ff607 into ReactiveX:0.20.x Sep 5, 2014
@benjchristensen benjchristensen changed the title Make TakeUntil obey Rx contract Make TakeUntil obey Rx serialization contract Sep 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants