Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RxScala: Fix infinite recursive onStart call in Subscriber #1641

Merged

Conversation

jbripley
Copy link
Contributor

Without this fix, when subscribing using a new Subscriber, onStart would be called in an infinite loop. Giving a strack trace similar to this:

java.lang.StackOverflowError
    at rx.lang.scala.SubscriberTests$$anon$1.onStart(SubscriberTests.scala:65)
    at rx.lang.scala.Subscriber$$anon$1.onStart(Subscriber.scala:8)
    at rx.lang.scala.Subscriber$class.onStart(Subscriber.scala:43)
    at rx.lang.scala.SubscriberTests$$anon$1.onStart(SubscriberTests.scala:65)
    at rx.lang.scala.Subscriber$$anon$1.onStart(Subscriber.scala:8)
    at rx.lang.scala.Subscriber$class.onStart(Subscriber.scala:43)

@cloudbees-pull-request-builder

ReactiveX » RxJava » RxJava-pull-requests #1 FAILURE
Looks like there's a problem with this pull request

@cloudbees-pull-request-builder

RxJava-pull-requests #1542 SUCCESS
This pull request looks good

@zsxwing
Copy link
Member

zsxwing commented Aug 29, 2014

Good catch. LGTM.

benjchristensen added a commit that referenced this pull request Aug 30, 2014
RxScala: Fix infinite recursive onStart call in Subscriber
@benjchristensen benjchristensen merged commit 5ee6073 into ReactiveX:0.20.x Aug 30, 2014
@benjchristensen
Copy link
Member

Please also fix this in the new RxScala project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants