RxScala: Simplify doOnCompleted/Terminate, finallyDo callback usage #1345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RxJava-pull-requests #1255 SUCCESS |
|
LGTM. |
|
Is it really a breaking change? I can't test it fully right now, but both new and old code should work with this new signature? val o = List("red", "green", "blue").toObservable.doOnTerminate { println("terminate") }
val o = List("red", "green", "blue").toObservable.doOnTerminate(() => println("terminate")) |
|
Sorry. Never realized both two have the same signature in the JVM byte code until I used javap to take a look today. |
benjchristensen
added a commit
that referenced
this pull request
Jun 12, 2014
RxScala: Simplify doOnCompleted/Terminate, finallyDo callback usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #1342