Make Future receive NoSuchElementException when the BlockingObservable is empty #1337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsxwing
changed the title
|
RxJava-pull-requests #1247 SUCCESS |
|
RxJava-pull-requests #1248 SUCCESS |
|
RxJava-pull-requests #1249 SUCCESS |
benjchristensen
added a commit
that referenced
this pull request
Jun 12, 2014
Make Future receive NoSuchElementException when the BlockingObservable is empty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now
Future.getwill returnnullif there is a singlenullin the BlockingObservable, or it is empty. People cannot distinguish between these two cases.This PR has 2 breaking changes:
NoSuchElementExceptionrather than returningnullwhen the BlockingObservable is empty.IllegalStateExceptiontoIllegalArgumentExceptionwhen the BlockingObservable emits more than one items. This is because I usedsingledirectly.