RxScala: Add convenience method for adding unsubscription callback #1300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbripley
changed the title
|
RxJava-pull-requests #1198 SUCCESS |
| * @param unsubscriptionCallback callback to run when unsubscribed | ||
| */ | ||
| final def add(unsubscriptionCallback: => Unit): Unit = { | ||
| asJavaSubscriber.add(new rx.Subscription { |
There was a problem hiding this comment.
unsubscriptionCallback is not a good name in Rx. s should be enough. And why not use add(Subscription(s))? The codes here are almost same as Subscription.apply(u: => Unit).
There was a problem hiding this comment.
True, totally missed apply(). I'll change parameter to u instead and use Subscription.apply.
|
RxJava-pull-requests #1199 SUCCESS |
|
RxJava-pull-requests #1200 SUCCESS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements enhancement detailed in #1258