Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check unsubscribe within observable from future #1291

Merged
merged 2 commits into from
May 30, 2014
Merged

Check unsubscribe within observable from future #1291

merged 2 commits into from
May 30, 2014

Commits on May 30, 2014

  1. 2 new tests for OnSubscribeToObservableFuture 

    1) Creating an Observable from an already-cancelled Future should emit nothing (equivalent to Observable.never())
   (it currently emits onError(CancellationException)
2) Creating an Observable from a Future then unsubscribeing immediately before Future.get()
   unblocks should be an Observable.never().  This test already passes.
    @mattrjacobs
    mattrjacobs committed May 30, 2014
    Configuration menu
    Copy the full SHA
    2d11791 View commit details
    Browse the repository at this point in the history

  2. Modify OnSubscribeToObservableFuture to return early if unsubscribe w… 

    …ithout emitting anything
    @mattrjacobs
    mattrjacobs committed May 30, 2014
    Configuration menu
    Copy the full SHA
    e285a7b View commit details
    Browse the repository at this point in the history