Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReplaySubject remove replayState CHM and related SubjectObserver changes #1287

Merged
merged 2 commits into from
May 30, 2014

Conversation

akarnokd
Copy link
Member

For issue #1204

This change should help avoid CHM garbage (although boxed Integers will still fly around). In addition, I moved the NotificationLite around to make room for the index. I've also removed the callback onAdd in PublishSubject because it was unnecessary.

@cloudbees-pull-request-builder

RxJava-pull-requests #1188 SUCCESS
This pull request looks good

@benjchristensen
Copy link
Member

Awesome. I'll try this against the tests I was doing.

@benjchristensen
Copy link
Member

This looks like it does improve performance and object allocation. When using my Hystrix tests I get this:

new

Run: 10 - 208,720 ops/sec 
Run: 11 - 209,834 ops/sec 
Run: 12 - 209,217 ops/sec 
Run: 13 - 208,026 ops/sec 
Run: 14 - 211,303 ops/sec 

old

Run: 10 - 153,523 ops/sec 
Run: 11 - 162,289 ops/sec 
Run: 12 - 162,347 ops/sec 
Run: 13 - 159,153 ops/sec 
Run: 14 - 160,194 ops/sec 

new

Run: 10 - 572,909 ops/sec 
Run: 11 - 568,987 ops/sec 
Run: 12 - 572,521 ops/sec 
Run: 13 - 571,594 ops/sec 
Run: 14 - 572,979 ops/sec 

old

Run: 10 - 487,791 ops/sec 
Run: 11 - 491,292 ops/sec 
Run: 12 - 480,598 ops/sec 
Run: 13 - 484,517 ops/sec 
Run: 14 - 489,212 ops/sec 

Old:

old

New:

new

Now I need to go give Hystrix some love too as there are some obvious things to go solve there.

Thanks @akarnokd for getting to this so quickly.

benjchristensen added a commit that referenced this pull request May 30, 2014
ReplaySubject remove replayState CHM and related SubjectObserver changes
@benjchristensen benjchristensen merged commit b0e87db into ReactiveX:master May 30, 2014
@akarnokd akarnokd deleted the SubjectObserverPerf branch May 30, 2014 16:45
@benjchristensen benjchristensen mentioned this pull request Jun 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants