Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to future cancellation #1267

Closed
wants to merge 3 commits into from
Closed

Fix to future cancellation #1267

wants to merge 3 commits into from

Commits on May 27, 2014

  1. 2 new tests for OperatorToObservableFuture 

    1) Creating an Observable from an already-cancelled Future should emit nothing (equivalent to Observable.never())
   (it currently emits onError(CancellationException)
2) Creating an Observable from a Future then unsubscribeing immediately before Future.get()
   unblocks should be an Observable.never().  This test already passes.
    @mattrjacobs
    mattrjacobs committed May 27, 2014
    Configuration menu
    Copy the full SHA
    5f3a820 View commit details
    Browse the repository at this point in the history

  2. Bugfix to do early-return from unsubscribed Future

    @mattrjacobs
    mattrjacobs committed May 27, 2014
    Configuration menu
    Copy the full SHA
    9f61083 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2014

  1. OperatorToObservableFuture refuse to emit onError if already unsubscr… 

    …ibed
    @mattrjacobs
    mattrjacobs committed May 28, 2014
    Configuration menu
    Copy the full SHA
    272d8ca View commit details
    Browse the repository at this point in the history