SafeSubscriber memory reduction #1237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RxJava-pull-requests #1138 SUCCESS |
benjchristensen
added a commit
that referenced
this pull request
May 21, 2014
SafeSubscriber memory reduction
|
Thanks. I think we probably should do this all over. I haven't merged my change to |
|
Oh, you already have a PR for |
|
@akarnokd @benjchristensen why was there a change from boolean to int? |
|
There is no AtomicBooleanFieldUpdater and the nearest thing is an AtomicIntegerFieldUpdater. Since classes are padded to 4-8 byte boundaries anyway, moving from 1 byte boolean to 4 byte integer is no extra overhead. |
|
oh I just checked you are right. that explains a lot, but I have no clue why they didn't add that. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1204. This saves 24 bytes per instance.