-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ReplaySubject enhancement with time and/or size bounds #1223
ReplaySubject enhancement with time and/or size bounds #1223
Conversation
RxJava-pull-requests #1130 SUCCESS |
import rx.schedulers.TestScheduler; | ||
import rx.subjects.PublishSubject; | ||
|
||
public class OperatorReplayTest { | ||
@Test | ||
public void testBoundedList() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are these unit tests being deleted? Are they invalid behavior?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW ... I tried seeing if they had been moved, but I don't see the names of these tests elsewhere, so perhaps they were renamed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They were testing the internal virtual list implementation in the CustomReplaySubject. Now that it is gone, there is no need for the test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, okay. Thanks.
Thank you for this refactor ... it looks like it was tedious! Just a simple question above and then will merge. |
ReplaySubject enhancement with time and/or size bounds
Reapplied the enhancements to bring size and/or time bound
ReplaySubject
capabilities while exposing a single subject class (i.e., no separate BoundedReplaySubject or CustomReplaySubject). It now uses the renewedSubjectSubscriptionManager
.In addition, I've moved a confusing behavior from SubjectObserver into AsyncSubject where it belongs.