-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix assert message format #7351
Conversation
Codecov Report
@@ Coverage Diff @@
## 3.x #7351 +/- ##
============================================
- Coverage 99.58% 99.53% -0.06%
+ Complexity 6783 6778 -5
============================================
Files 751 751
Lines 47482 47482
Branches 6378 6378
============================================
- Hits 47286 47261 -25
- Misses 88 95 +7
- Partials 108 126 +18
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the error messages be tested against that regex to ensure that it works?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, please add tests that verify the error messages against the intended regex.
Fix assert message format (ReactiveX#7351)
This PR is related to a previous one I opened: #7345
I've made a mistake when I tested regex because
\nexpected: (.*)\n\s*got: (.*)
does not allow prefixes.I changed assert messages to use suffixes instead of prefixes.
Sorry about that !