Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRs failing #666

Closed
akarnokd opened this issue Dec 23, 2013 · 3 comments
Closed

PRs failing #666

akarnokd opened this issue Dec 23, 2013 · 3 comments

Comments

@akarnokd
Copy link
Member

Due to refactored subscriptions:

  • OperationTakeLast - I'm about to submit a PR for this
  • Scala override attempt of the now final class:
rxjava-scala\src\main\scala\rx\lang\scala\subscriptions\BooleanSubscription.scala:30: error: illegal inheritance from final class BooleanSubscription
override val asJavaSubscription: rx.subscriptions.BooleanSubscription = new rx.subscriptions.BooleanSubscription() {

Is someone working on this latter?

@headinthebox
Copy link
Contributor

I'll fix the Scala one; previous there was no overload of BelleanSubscription.create that took an action.

@akarnokd
Copy link
Member Author

Thanks @headinthebox . The Scala compiler isn't that nice with me as with you.

@benjchristensen
Copy link
Member

Fixed.

jihoonson pushed a commit to jihoonson/RxJava that referenced this issue Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants