Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Maybe incorrect or missing marbles (tracking issue) #5806

Closed
akarnokd opened this issue Jan 10, 2018 · 2 comments · Fixed by #6897
Closed

3.x: Maybe incorrect or missing marbles (tracking issue) #5806

akarnokd opened this issue Jan 10, 2018 · 2 comments · Fixed by #6897

Comments

@akarnokd
Copy link
Member

akarnokd commented Jan 10, 2018

  • amb: missing diagram
  • ambArray: missing diagram
  • concat(Iterable): missing diagram
  • concat(Publisher): missing diagram
  • concat(Publisher, int): missing diagram
  • concatArray: missing diagram
  • concatArrayDelayError: indicate error delayed, 1 marble per source
  • concatArrayEager: missing diagram
  • concatDelayError(Iterable): missing diagram
  • concatDelayError(Publisher): missing diagram
  • concatDelayError(Publisher, int): fix overlap/misalignment inside the operator box
  • concatEager(Iterable): missing diagram
  • concatEager(Publisher): missing diagram
  • create: missing diagram
  • defer: missing diagram
  • error(Callable): indicate callable returns the error
  • fromAction: missing diagram
  • fromCompletable: missing diagram
  • fromSingle: missing diagram
  • fromCallable: missing diagram
  • fromFuture(Future): operator name in the box, indicate Future is the parameter
  • fromFuture(Future, long, TimeUnit): operator name in the box, indicate Future is the parameter, indicate timeout
  • fromRunnable: missing diagram
  • merge(Iterable): missing diagram
  • merge(Publisher): missing diagram
  • merge(Publisher, int): missing diagram
  • mergeArray: missing diagram
  • mergeArrayDelayError: one marble per Maybe source
  • mergeDelayError(Iterable): one marble per Maybe source
  • mergeDelayError(Publisher): one marble per Maybe source
  • mergeDelayError(Maybe, Maybe, ...): one marble per Maybe source
  • sequenceEqual + 1: result should be Single.
  • timer + 1: result should be Maybe
  • using + 1: rework to indicate the created Maybe
  • wrap: missing marble
  • zip(Iterable): one marble per Maybe source, result should be Maybe
  • zip(Maybe, Maybe, ...) + 8: one marble per Maybe source, result should be Maybe
  • zipArray: one marble per Maybe source, result should be Maybe
  • ambWith: one marble per Maybe source, result should be Maybe
  • as: missing diagram operator removed
  • blockingGet + 1: missing diagram
  • cache: one marble per Maybe source, result should be Maybe
  • cast: missing diagram
  • compose: missing diagram
  • concatMap: indicate Maybe target, indicate empty source
  • concatWith: one marble per Maybe source, result should be Maybe, operator name, indicate other is a parameter
  • contains: one marble per Maybe source, result should be Single, empty case
  • count: one marble per maybe, operator name, result should be Single, empty case
  • defaultIfEmpty: non-empty case, result should be Maybe
  • delay(time) + 3: one marble per Maybe source, result should be Maybe
  • delay(Publisher): one marble per Maybe, one signal by the Publisher, empty publisher case
  • delaySubscription(Publisher): missing diagram
  • delaySubscription(time) + 1: one marble per Maybe source, result should be Maybe
  • doAfterSuccess: missing diagram
  • doAfterTerminate: operator name, one marble per Maybe, result should be Maybe
  • doFinally: missing diagram
  • doOnDispose: missing diagram
  • doOnComplete: one marble per Maybe, result should be Maybe
  • doOnError: missing diagram
  • doOnEvent: missing diagram
  • doOnSubscribe: missing diagram
  • doOnSuccess: missing diagram
  • doOnTerminate: one marble per Maybe, result should be Maybe
  • filter: one marble per Maybe, result should be Maybe
  • flatMap(Function, Function, Callable): one marble per Maybe, result should be Maybe
  • flatMap(Function, BiFunction): one marble per Maybe, result should be Maybe
  • flatMapObservable: should be mapped into an Observable
  • flatMapPublisher: indicate backpressure
  • flatMapSingle: indicate empty maybe results in error
  • flatMapSingleElement: operator name, indicate empty maybe
  • flatMapCompletable: indicate empty maybe
  • hide: missing diagram
  • ignoreElement: operator name, one marble per Maybe, result should be Maybe
  • isEmpty: result should be Single
  • mergeWith: operator name, one marble per Maybe, indicate backpressure
  • ofType: one marble per Maybe
  • onErrorComplete + 1: missing diagram
  • onErrorResumeNext: one marble per Maybe, result should be Maybe
  • onErrorResumeWith: one marble per Maybe, result should be Maybe
  • onErrorReturn: one marble per Maybe, result should be Maybe, indicate callback
  • onErrorReturnItem: operator name, one marble per Maybe, result should be Maybe, indicate normal outcome
  • onExceptionResumeNext: operator takes a Maybe source directlyˇ operator removed
  • onTerminateDetach: missing diagram
  • repeat + 1: one marble per source, indicate backpressure, indicate repeat conditions
  • repeatUntil: operator name, repeat condition, indicate backpressure
  • repeatWhen: one marble per Maybe, indicate backpressure
  • retry + 2: one marble per Maybe, result should be Maybe, indicate repeat conditions
  • retry(int, Predicate): missing diagram
  • retry(Predicate): missing diagram
  • retryUntil: missing diagram
  • retryWhen: one marble per Maybe, output should be Maybe
  • switchIfEmpty + 1: improve diagrams, indicate argument type
  • takeUntil + 1: one marble per Maybe, output should be Maybe
  • timeout + 3: one marble per Maybe, output should be Maybe
  • timeout(MaybeSource): missing diagram
  • timeout(MaybeSource, MaybeSource): missing diagram
  • timeout(Publisher): missing diagram
  • timeout(Publisher, MaybeSource): missing diagram
  • to: missing diagram
  • toFlowable: missing diagram
  • toObservable: missing diagram
  • toSingle + 1: missing diagram
  • unsubscribeOn: missing diagram
  • zipWith: one marble per Maybe, output should be Maybe
@akarnokd
Copy link
Member Author

Here is the Excel file I draw the diagrams in: https://drive.google.com/file/d/1di67kFJEuiLPyq14JlnV3vFl-muaCMfH/view?usp=sharing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants
@akarnokd and others